Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporate_indirect_nodes should pass if not needed #4214

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Nov 5, 2021

resolves #4213

Quick opportunistic performance boost! Adjusts a method that I was responsible for adding, way back in v0.20...

Before

Screenshot 2021-11-05 at 08 38 36

After

Screenshot 2021-11-05 at 08 42 45

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Nov 5, 2021
@jtcohen6 jtcohen6 marked this pull request as ready for review November 5, 2021 08:12
@jtcohen6 jtcohen6 requested review from gshank and iknox-fa November 5, 2021 08:12
@iknox-fa
Copy link
Contributor

iknox-fa commented Nov 5, 2021

Love it! Embrace the profiler!

Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtcohen6 jtcohen6 merged commit 3dab058 into main Nov 5, 2021
@jtcohen6 jtcohen6 deleted the perf/skip-method-if-not-needed branch November 5, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasted time spent in incorporate_indirect_nodes during node selection
3 participants