[#3867] Turn on partial parsing by default #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
force-pushed
the
default_partial_parsing
branch
from
ac2bea4 to
d167916
Compare
gshank
force-pushed
the
default_partial_parsing
branch
from
d167916 to
074eafa
Compare
jtcohen6
reviewed
Oct 1, 2021
| @@ -41,7 +41,7 @@ | |||
| "STATIC_PARSER": True, | |||
| "WARN_ERROR": False, | |||
| "WRITE_JSON": True, | |||
| "PARTIAL_PARSE": False, | |||
| "PARTIAL_PARSE": True, | |||
There was a problem hiding this comment.
Yeah. Some parts of the code want the Z ending, and some parts don't, apparently. I moved the kludging of 'generated_at' into a post serialization method in BaseArtifactMetadata.
Comment on lines
+561
to
+567
| # We don't want to have stale generated_at dates | ||
| manifest.metadata.generated_at = datetime.utcnow() | ||
| # or invocation_ids | ||
| if dbt.tracking.active_user: | ||
| manifest.metadata.invocation_id = dbt.tracking.active_user.invocation_id | ||
| else: | ||
| manifest.metadata.invocation_id = None |
gshank
force-pushed
the
default_partial_parsing
branch
2 times, most recently
from
24eac63 to
f393481
Compare
|
The remaining test failure is because we're not handling 'vars' in partial parsing. To fix it the right way we'd have to implement one of the 'vars' solutions we've discussed. (For the case of this test, it's vars passed in as cli args in the rpc server.) Or we could turn off partial parsing for the test. |
gshank
force-pushed
the
default_partial_parsing
branch
from
f393481 to
e0d2b02
Compare
|
Have modified the tests to use the --no-partial-parse flag. The issues with vars and env_vars are well known and on the roadmap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3867
Description
Turn on partial parsing by default.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.