Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable deprecation: materialization-return #3896

Closed
emmyoop opened this issue Sep 16, 2021 · 0 comments · Fixed by #3893
Closed

Enable deprecation: materialization-return #3896

emmyoop opened this issue Sep 16, 2021 · 0 comments · Fixed by #3893
Assignees
@emmyoop

Comments

@emmyoop
Copy link
Member

emmyoop commented Sep 16, 2021 •
edited
Loading

Introduced in: v0.15
In the last week, raised by: 14 projects (<1%)

https://github.com/dbt-labs/dbt/blob/96083dcaf51ab7725f1b554891581e1522e32d7d/core/dbt/task/run.py#L208-L225

  • Remove the conditional branch if isinstance(result, str) that raises a deprecation warning and handles the string result. If result isn't a dictionary that passes _validate_materialization_relations_dict, we should just raise an exception.
  • Remove MaterializationReturnDeprecation from the list of active deprecations

Originally posted by @jtcohen6 in #2798 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmyoop emmyoop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed deprication for materialization-return and replaced it with a… dbt-labs/dbt-core
1 participant
@emmyoop