-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slim down the manifest.json artifact #2169
Comments
#2220 removes
This was as straightforward as it seemed.
Currently we use this in the template caching code. I've remove it from parsed macros by making the cache operate on the macro_sql instead of the full file. I'm not sure what impact that will have on performance in the average dbt project (positive or negative). I think it might hurt error messages, too. Some other things I thought of:
|
Some preliminary work:
The size comes from I spent a bit of time on the omitting defaults code - it was less helpful than I hoped and involved some breaking changes to how hologram serializes things, so that's probably a dead end. Significant further changes are probably going to have really diminishing returns. |
@beckjake awesome! An 80% reduction from removing Can you open up a PR for this change? |
Describe the feature
We've seen some pretty big manifests in the wild. The size of this file is necessarily going to scale linearly with the number of objects in your project + lines of code, but if there are obvious things we should do to slim down this file size, we should do them.
Ideas:
Who will this benefit?
This should make websites (like the docs site) more responsive and faster to load
The text was updated successfully, but these errors were encountered: