Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on parse errors (#1493) #1751

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Conversation

beckjake
Copy link
Contributor

Fix #1493

  • Raise exceptions where we used to (usually) just warn, kind of --strict all the time
  • Fix some error messages to be a bit more informative (though you still kind of have to piece stuff together on large, deeply nested validation errors)
  • Hoisted logging about those errors up into the GraphLoader itself, which then re-raises exceptions to ensure dbt actually stops. This is a bit more useful, I think, given that we are failing immediately in all those cases now.
  • We had some tests that asserted the opposite of what this PR accomplishes, so I've reversed those accordingly

@beckjake beckjake requested a review from drewbanin September 13, 2019 20:48
@cla-bot cla-bot bot added the cla:yes label Sep 13, 2019
@beckjake beckjake force-pushed the fix/fail-on-parse-errors branch from fd5307b to 1d91890 Compare September 13, 2019 20:55
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Ship it :)

@beckjake beckjake merged commit cbd824c into dev/louisa-may-alcott Sep 16, 2019
@beckjake beckjake deleted the fix/fail-on-parse-errors branch September 16, 2019 15:49
@beckjake beckjake mentioned this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBT Operations (like 'run', 'seed', etc.) run successfully even when issues parsing .yml files
2 participants