Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Deprecation warning for custom microbatch macros is being fired incorrectly #10994

Closed
2 tasks done
QMalcolm opened this issue Nov 13, 2024 · 0 comments · Fixed by #10989
Closed
2 tasks done

[Bug] Deprecation warning for custom microbatch macros is being fired incorrectly #10994

QMalcolm opened this issue Nov 13, 2024 · 0 comments · Fixed by #10989
Assignees
Labels
bug Something isn't working

Comments

@QMalcolm
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

A deprecation warning about custom microbatch marcos is issued IFF all the following are true

  1. a project DOESNT have a custom "microbatch" macro
  2. the require_batched_execution_for_custom_microbatch_strategy is set to False
  3. the project has a "microbatch" model

Expected Behavior

A deperecation warning about custom microbatch macros should only be issued IFF all the following are true

  1. a project DOES have a custom "microbatch" macro
  2. the require_batched_execution_for_custom_microbatch_strategy is set to False
  3. the project has a "microbatch" model

Steps To Reproduce

  1. get dbt-postgres 1.9.0b1
  2. create a microbatch model in your project (without a custom "microbatch" macro)
  3. run dbt run
  4. observe the deprecation warning

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants