Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] canceling a run of a microbatch model should cause remaining batches to be skipped #10862

Closed
2 tasks done
Tracked by #10624
graciegoheen opened this issue Oct 16, 2024 · 1 comment · Fixed by #10879
Closed
2 tasks done
Tracked by #10624
Assignees
Labels
bug Something isn't working microbatch Issues related to the microbatch incremental strategy

Comments

@graciegoheen
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Cancelling a run doesn’t immediately stop all the related batch runs. The remaining batches continue to build.

Expected Behavior

All the batches cancel out regardless of which batch we initiate the cancellation action/request.

Steps To Reproduce

See here

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

snowflake

Additional Context

No response

@brian-franklin
Copy link

I also found that when an error is encountered in the model logic it does not stop the remaining batches from attempting to run resulting in the same error reporting for all batches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working microbatch Issues related to the microbatch incremental strategy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants