Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-628] Remove explicit dependency & tight version pin on agate #777

Closed
jtcohen6 opened this issue Jun 19, 2023 · 0 comments · Fixed by #778
Closed

[ADAP-628] Remove explicit dependency & tight version pin on agate #777

jtcohen6 opened this issue Jun 19, 2023 · 0 comments · Fixed by #778
Labels
type:task

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 19, 2023 •
edited
Loading

Conversation in #774 (comment)

dbt-bigquery specifies an explicit dependency on agate, with minor version pin (~=) to agate v1.6

All other adapters just use the transitive dependency from dbt-core. This makes it more difficult to loosen the version pin, as we're trying to do in dbt-labs/dbt-core#7368, for greater consistency/flexibility across the board.
@github-actions github-actions bot changed the title Remove explicit dependency & tight version pin on agate [ADAP-628] Remove explicit dependency & tight version pin on agate Jun 19, 2023
@jtcohen6 jtcohen6 mentioned this issue Jun 19, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rm agate as explicit dep dbt-labs/dbt-bigquery
1 participant
@jtcohen6