-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADAP-879] [Feature] Query Cancellation #917
Comments
Great feature 👍 |
Ideally this could be handled in dbt-core, have opened this discussion: dbt-labs/dbt-core#8522 |
@colin-rogers-dbt
If that standard is not finalized yet, I'd also be happy to chime in and follow along in its design, eventually working it back into the implementation proposed in this PR. Thank you for your time and for considering this issue and PR! |
I recently encountered this issue and I'm really excited about it. I'm curious to know what the roadmap is for addressing this. |
Is this your first time submitting a feature request?
Describe the feature
When a dbt-bigquery run is interrupted running queries should be canceled.
Describe alternatives you've considered
Relying on timeouts possibly added by this PR. While timeouts can help, it does not solve the issue of wasted resources for local query cancelation.
Who will this benefit?
This will benefit users of dbt-bigquery in two scenarios:
When executions triggered during local development are interrupted, this feature will avoid wasting compute. This will help reduce cost, especially when users are using on-demand billing. Additionally, it will save users time as they will not need to use the BQ ui and api to identify and cancel query jobs.
This will allow for orchestrator-configured timeouts (e.g. airflow) to safely cancel model execution. This will save compute and ensure retries don't rerun a query that was unknowingly completed or still running.
Are you interested in contributing this feature?
Yes #918
Anything else?
No response
The text was updated successfully, but these errors were encountered: