Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating passenv in tox #411

Merged
merged 3 commits into from
Dec 7, 2022
Merged

updating passenv in tox #411

merged 3 commits into from
Dec 7, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Dec 7, 2022

resolves #

Description

In tox 4, space-separated variables specified for passenv are not passed into the container.

[testenv:inline]
passenv = FOO BAR

☝️ doesn't work on tox 4

[testenv:separate-lines]
passenv =
    FOO
    BAR

Checklist

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge & backport away.

@@ -0,0 +1,8 @@
kind: Under the Hood
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably doesn't need a changelog entry, since it's not a change to code we actually release/distribute — but it's nbd

@McKnight-42 McKnight-42 merged commit 24bed99 into main Dec 7, 2022
@McKnight-42 McKnight-42 deleted the mcknight/fix-env branch December 7, 2022 21:31
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

The backport to 1.2.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-411-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 24bed99bfb48d76d36785362b86e1d9dba9c1ae9
# Push it to GitHub
git push --set-upstream origin backport-411-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest

Then, create a pull request where the base branch is 1.2.latest and the compare/head branch is backport-411-to-1.2.latest.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

The backport to 1.1.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1.latest 1.1.latest
# Navigate to the new working tree
cd .worktrees/backport-1.1.latest
# Create a new branch
git switch --create backport-411-to-1.1.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 24bed99bfb48d76d36785362b86e1d9dba9c1ae9
# Push it to GitHub
git push --set-upstream origin backport-411-to-1.1.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1.latest

Then, create a pull request where the base branch is 1.1.latest and the compare/head branch is backport-411-to-1.1.latest.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-411-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 24bed99bfb48d76d36785362b86e1d9dba9c1ae9
# Push it to GitHub
git push --set-upstream origin backport-411-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-411-to-1.0.latest.

github-actions bot pushed a commit that referenced this pull request Dec 7, 2022
* fixing env write out in tox due to 4.0.0 release

* finish tox alignment and add changelog

(cherry picked from commit 24bed99)
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

The backport to 1.2.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-411-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 24bed99bfb48d76d36785362b86e1d9dba9c1ae9
# Push it to GitHub
git push --set-upstream origin backport-411-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest

Then, create a pull request where the base branch is 1.2.latest and the compare/head branch is backport-411-to-1.2.latest.

McKnight-42 added a commit that referenced this pull request Dec 8, 2022
* manual backport of tox fix post 4.0.0 release

* finsish format changes in tox
colin-rogers-dbt pushed a commit that referenced this pull request Dec 9, 2022
* updating passenv in tox (#411)

* fixing env write out in tox due to 4.0.0 release

* finish tox alignment and add changelog

(cherry picked from commit 24bed99)

* minor fix for format

* remove uneeded changie entry

Co-authored-by: Matthew McKnight <[email protected]>
Co-authored-by: Matthew McKnight <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants