Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-904] Add test integration test for BigQuery-specific adapter_response contents #235

Closed
McKnight-42 opened this issue Jul 25, 2022 · 2 comments

Comments

@McKnight-42
Copy link
Contributor

Describe the feature

a BigQuery specific set of integration/functional tests to check the adapter response contents would be great to double check build of contents and verify new feature adds such as

Who will this benefit?

users/maintainers will all have viable ways to trust the bigquery adapter_response

@McKnight-42 McKnight-42 added enhancement New feature or request triage labels Jul 25, 2022
@github-actions github-actions bot changed the title Add test integration test for BigQuery-specific adapter_response contents [CT-904] Add test integration test for BigQuery-specific adapter_response contents Jul 25, 2022
@jtcohen6
Copy link
Contributor

Thanks for opening @McKnight-42!

I added a test to dbt-snowflake that does something similar, by inspecting the results object to ensure the expected value of adapter_response["rows_affected"]: https://github.com/dbt-labs/dbt-snowflake/blob/main/tests/functional/adapter/test_incremental_run_result.py

@jtcohen6 jtcohen6 added tech_debt and removed enhancement New feature or request triage labels Jul 26, 2022
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants