Catch google NotFound exception as a DbtDatabaseError
#1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
colin-rogers-dbt
approved these changes
Oct 1, 2024
VersusFacit
approved these changes
Oct 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* catch google NotFound exception as a DbtDatabaseError * changelog (cherry picked from commit 8833c54)
mikealfare
added a commit
that referenced
this pull request
Oct 2, 2024
) * catch google NotFound exception as a DbtDatabaseError (cherry picked from commit 8833c54) Co-authored-by: Mike Alfare <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We were not catching a database exception and then returning the result as a runtime exception. This was caught in a test that was recently updated to expect a database exception. The functionality that changed used to not run this code at all, hence it used to pass.
Solution
Add another condition for catching database exceptions.
Checklist