Move code quality deps to precommit #1291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We wind up with a ton of dependabot updates, most of them for linting dependencies. We also have two versions of linting config, one in
.pre-commit-config.yaml
and one in separate config files. Since we generally run linting viapre-commit
, the latter doesn't get used.Solution
.pre-commit-config.yaml
pre-commit run
instead of calling directly (the tools will no longer be in the virtual environment)pre-commit run --all-files
Checklist