Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code quality deps to precommit #1291

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We wind up with a ton of dependabot updates, most of them for linting dependencies. We also have two versions of linting config, one in .pre-commit-config.yaml and one in separate config files. Since we generally run linting via pre-commit, the latter doesn't get used.

Solution

  • move all linting dependencies and config into .pre-commit-config.yaml
  • make sure linting calls use pre-commit run instead of calling directly (the tools will no longer be in the virtual environment)
  • make linting updates resulting from pre-commit run --all-files

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jul 18, 2024
@mikealfare mikealfare requested a review from a team as a code owner July 18, 2024 23:29
@cla-bot cla-bot bot added the cla:yes label Jul 18, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare mikealfare enabled auto-merge (squash) July 19, 2024 17:09
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the cleanup

@mikealfare mikealfare merged commit 8c0a192 into main Jul 24, 2024
20 checks passed
@mikealfare mikealfare deleted the move-code-quality-deps-to-precommit branch July 24, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants