Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] On first-run/full-refresh the incremental strategy of a model isn't validated #330

Closed
Tracked by #10624
QMalcolm opened this issue Oct 16, 2024 · 0 comments · Fixed by #331
Closed
Tracked by #10624
Assignees
Labels
bug Something isn't working incremental Incremental modeling with dbt

Comments

@QMalcolm
Copy link
Contributor

Presently, if the relation for an incremental model is being built for the first time (because the relation in the data warehouse doesn't exist) or if the incremental model is being run as a full refresh, then validation of the incremental strategy doesn't occur. Technically, for most incremental strategies, this is "okay". That is because the incremental strategy isn't used when creating the relation for the first time or during a full refresh. The exception to that is for microbatch incremental models. Additionally, this leads to an experience where if you write a new incremental model (with an invalid strategy) and then run it to ensure it works, everything will seem fine. You won't know anything is wrong until it is run for the second time. This can be a jarring experience, and is a bug.

@QMalcolm QMalcolm added bug Something isn't working incremental Incremental modeling with dbt labels Oct 16, 2024
@QMalcolm QMalcolm self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working incremental Incremental modeling with dbt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant