Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] warn users that dbt-core~=1.8.0 needs to be explicitly installed #139

Closed
3 tasks done
dataders opened this issue Mar 27, 2024 · 1 comment
Closed
3 tasks done
Labels
enhancement New feature or request triage

Comments

@dataders
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-adapter functionality, rather than a Big Idea better suited to a discussion

Describe the feature

I propose we add a generic warning to dbt-adapter's setup.py that says something like the below

As of dbt-core>=1.8, users must install both an adapter and dbt core, ie
pip install dbt-ADAPTER dbt-core
For more information, see https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.8#new-dbt-core-adapter-installation-procedure

Copilot suggested to me the below addition to setup.py.

import warnings

warnings.warn("""
As of dbt-core>=1.8, users must install both an adapter and dbt core, ie
`pip install dbt-ADAPTER dbt-core`
For more information, see https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.8#new-dbt-core-adapter-installation-procedure
""")

However, given setup.py is being "deprecated" in favor of pyproject.toml, this is a stop-gap solution. IMHO, this is fine as the warning exists solely to guide users upgrading from versions less than 1.8 to versions greater than or equal to 1.8

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@dataders dataders added enhancement New feature or request triage labels Mar 27, 2024
@amychen1776
Copy link
Contributor

I would love to tackle this but due to capacity, we will not be able to pick this up. Appreciate you through!

@amychen1776 amychen1776 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

2 participants