Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: If IP is unreachable, reduce poll frequency #7

Open
madtempest opened this issue Jul 18, 2024 · 2 comments
Open

Feature Request: If IP is unreachable, reduce poll frequency #7

madtempest opened this issue Jul 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@madtempest
Copy link

madtempest commented Jul 18, 2024

Is your feature request related to a problem? Please describe:
I have the GW10KAU-DT model which shuts down when it is not generating, causing the wifi module to go offline, however the plugin spams the logs of Homebridge with "new value = -1" forever until the device returns to generating and reconnects to the network.

Describe the solution you'd like:
Add logic to the plugin that checks for the IP being live before it polls for data. If the IP is not live, do not attempt to poll again for say, 1 hour OR allow the plugin to gather weather data/sunrise time from a source within Homebridge such as https://github.com/naofireblade/homebridge-weather-plus#readme

Describe alternatives you've considered:
None, new to this plugin.

Additional context:
I'm still waiting to confirm that the device shutting down when it's not generating is normal.

@madtempest madtempest added the enhancement New feature or request label Jul 18, 2024
@dblommesteijn
Copy link
Owner

dblommesteijn commented Jul 18, 2024

Thank you for your suggestion, there is some backoff strategy, but this is indeed flooding the logs still. I will put it on the roadmap.

PS. Polling will probably still happen on the background because you will never know when the device will become available again the the morning when the sun gets up.

@madtempest
Copy link
Author

Thank you for your suggestion, there is some backoff strategy, but this is indeed flooding the logs still. I will put it on the roadmap.

PS. Polling will probably still happen on the background because you will never know when the device will become available again the the morning when the sun gets up.

Thank you!

On the topic of the sun, that's why I was suggesting some kind of integration that can read expected sunrise from a weather forecast service perhaps, so that the plugin can "estimate," a clock time to start ramping up polling again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants