Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playplay.io rank command returns users not on our team #104

Closed
jbcpollak opened this issue Apr 27, 2016 · 5 comments
Closed

playplay.io rank command returns users not on our team #104

jbcpollak opened this issue Apr 27, 2016 · 5 comments

Comments

@jbcpollak
Copy link

When we run @pongbot rank we get a dump of 100s of users not on our team. In addition to being annoying, it's probably some what of a security risk since it leaks handles from other user's Slack accounts.

@pongbot leaderboard doesn't seem to have this problem.

See screenshot (the full post is many pages long):

screen shot 2016-04-27 at 7 31 12 pm

@dblock dblock added the bug? label Apr 28, 2016
@dblock dblock closed this as completed in 0741321 Apr 28, 2016
@dblock dblock added confirmed bug and removed bug? labels Apr 28, 2016
@dblock
Copy link
Owner

dblock commented Apr 28, 2016

This has been fixed, thanks for reporting it.

Please consider sponsoring my open-source work and the playplay.io service with a 100$ donation, get your company logo on http://playplay.io and keep the service free for everyone else. Click here. See http://playplay.io/#sponsors for more info.

@jbcpollak
Copy link
Author

Thanks for the rapid response! We just got our pingpong table setup yesterday - if we adopt pongbot we will consider sponsorship. :)

Also related to rank, I am unranked, when I run pongbot rank I get the following output (my handle is undefined):

pongbotBOT [8:37 AM] 
undefined: not ranked
dreadpirateroberts: not ranked
tim: not ranked

It seems to be showing everyone who is unranked. The same is true for pongbot rank undefined.

But if I run pongbot rank fuzzball, I see:

2. fuzzball: 0 wins, 1 loss (elo: -48)

Is this expected behavior?

@jbcpollak
Copy link
Author

BTW - We probably overlapped at Dog Patch - I was CTO at Assured Labor.

@dblock
Copy link
Owner

dblock commented Apr 28, 2016

That looks like a bug too. Care to open a new one? I'll take a look at fixing it. Also don't hesitate to PR a fix yourself :)

@jbcpollak
Copy link
Author

I looked into it, but I'm not a Ruby dev so jumping in might be difficult. I'll open a separate bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants