diff --git a/plugin/trino-sybase/src/main/java/io/trino/plugin/sybase/SybaseClient.java b/plugin/trino-sybase/src/main/java/io/trino/plugin/sybase/SybaseClient.java index acc677be678e..863a237c4a0d 100644 --- a/plugin/trino-sybase/src/main/java/io/trino/plugin/sybase/SybaseClient.java +++ b/plugin/trino-sybase/src/main/java/io/trino/plugin/sybase/SybaseClient.java @@ -61,13 +61,6 @@ public class SybaseClient private static final Joiner DOT_JOINER = Joiner.on("."); - @Override - public void createSchema(ConnectorSession session, String schemaName) - { - // TODO: Add try-catch for error message parsing (test cases patch) - super.createSchema(session, schemaName); - } - @Inject public SybaseClient(BaseJdbcConfig config, ConnectionFactory connectionFactory, IdentifierMapping identifierMapping) { diff --git a/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/SybaseQueryRunner.java b/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/SybaseQueryRunner.java index abee2b978a49..fc6fb0b6a763 100644 --- a/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/SybaseQueryRunner.java +++ b/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/SybaseQueryRunner.java @@ -13,12 +13,12 @@ */ package io.trino.plugin.sybase; -import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; +import io.airlift.log.Logger; +import io.airlift.log.Logging; import io.trino.Session; import io.trino.plugin.tpch.TpchPlugin; import io.trino.testing.DistributedQueryRunner; -import io.trino.testing.QueryRunner; import io.trino.tpch.TpchTable; import java.util.HashMap; @@ -35,16 +35,15 @@ private SybaseQueryRunner() {} private static final String TPCH_SCHEMA = "tpch"; - public static QueryRunner createSybaseQueryRunner(TestingSybaseServer server, TpchTable... tables) + public static DistributedQueryRunner createSybaseQueryRunner(TestingSybaseServer server, + Map extraProperties, + Map connectorProperties, + Iterable> tables) throws Exception { - return createSybaseQueryRunner(server, ImmutableMap.of(), ImmutableList.copyOf(tables)); - } - - public static QueryRunner createSybaseQueryRunner(TestingSybaseServer server, Map connectorProperties, Iterable> tables) - throws Exception - { - DistributedQueryRunner queryRunner = DistributedQueryRunner.builder(createSession()).build(); + DistributedQueryRunner queryRunner = DistributedQueryRunner.builder(createSession()) + .setExtraProperties(extraProperties) + .build(); try { queryRunner.installPlugin(new TpchPlugin()); queryRunner.createCatalog("tpch", "tpch"); @@ -75,4 +74,20 @@ private static Session createSession() .setSchema("dbo") .build(); } + + public static void main(String[] args) + throws Exception + { + Logging.initialize(); + + DistributedQueryRunner queryRunner = createSybaseQueryRunner( + new TestingSybaseServer(), + ImmutableMap.of("http-server.http.port", "8080"), + ImmutableMap.of(), + TpchTable.getTables()); + + Logger log = Logger.get(SybaseQueryRunner.class); + log.info("======== SERVER STARTED ========"); + log.info("\n====\n%s\n====", queryRunner.getCoordinator().getBaseUrl()); + } } diff --git a/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestSybaseConnectorTest.java b/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestSybaseConnectorTest.java index 4f6e782c499d..5e96856b60af 100644 --- a/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestSybaseConnectorTest.java +++ b/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestSybaseConnectorTest.java @@ -32,7 +32,7 @@ protected QueryRunner createQueryRunner() throws Exception { sybaseServer = new TestingSybaseServer(); - return createSybaseQueryRunner(sybaseServer, ImmutableMap.of(), REQUIRED_TPCH_TABLES); + return createSybaseQueryRunner(sybaseServer, ImmutableMap.of(), ImmutableMap.of(), REQUIRED_TPCH_TABLES); } @AfterClass(alwaysRun = true) diff --git a/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestSybasePlugin.java b/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestSybasePlugin.java index 0f463e61c510..2cdd2dd32318 100644 --- a/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestSybasePlugin.java +++ b/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestSybasePlugin.java @@ -28,6 +28,6 @@ public void testCreateConnector() { Plugin plugin = new SybasePlugin(); ConnectorFactory factory = getOnlyElement(plugin.getConnectorFactories()); - factory.create("test", ImmutableMap.of("connection-url", "jdbc:mariadb://test"), new TestingConnectorContext()).shutdown(); + factory.create("test", ImmutableMap.of("connection-url", "jdbc:jtds:sybase://testdb"), new TestingConnectorContext()).shutdown(); } } diff --git a/plugin/trino-sybase/src/test/resources/container-license-acceptance.txt b/plugin/trino-sybase/src/test/resources/container-license-acceptance.txt deleted file mode 100644 index ab843953ef7f..000000000000 --- a/plugin/trino-sybase/src/test/resources/container-license-acceptance.txt +++ /dev/null @@ -1 +0,0 @@ -microsoft/mssql-server-linux:2017-CU13 diff --git a/pom.xml b/pom.xml index badf01837808..c40e38c84e13 100644 --- a/pom.xml +++ b/pom.xml @@ -140,6 +140,7 @@ plugin/trino-resource-group-managers plugin/trino-session-property-managers plugin/trino-sqlserver + plugin/trino-sybase plugin/trino-teradata-functions plugin/trino-thrift plugin/trino-thrift-api