Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IHostApplicationLifetime needs to be singleton not singleton per tenant. #74

Open
dazinator opened this issue Sep 20, 2020 · 0 comments

Comments

@dazinator
Copy link
Owner

dazinator commented Sep 20, 2020

Seen an issue with tryign to register signal-r per tenant, in that it relies on IHostApplicationLifetime (provided by the host) to be signalled, in order to start it's background connection managment loop which does things like issue "Keep-alive" pings for connected clients.

The issue is that each tenant is currently getting their own instance of IHostApplicationLifetime because its registered by type, not by by isntance, so the child container creates its own instance per tenant.

Should perhaps add logic to register the application (existing) instance into each child container rather than add a type registration per tenant.

dotnet/aspnetcore#26056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant