Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable locking available ships #14

Open
ptmaroct opened this issue Aug 12, 2024 · 3 comments · May be fixed by #28
Open

Enable locking available ships #14

ptmaroct opened this issue Aug 12, 2024 · 3 comments · May be fixed by #28
Labels
critical burning issue, should be fixed on priority

Comments

@ptmaroct
Copy link
Member

Currently credit gets deducted on generation completion, in the meantime if user tries again to create a new website, they are able to. Implement locking or reduce credits as the start of generation when we are sure website will get created definitely
@ptmaroct ptmaroct added the critical burning issue, should be fixed on priority label Aug 13, 2024
@PREMPRAKASHSINGH
Copy link
Contributor

By credits we mean available_ships right?

Since we want to enable locking, how about deducting credits at the startProject event and in case it gets aborted due to any reasons then add back the deducted credits?

Let me know if this approach is fine, if yes then I will start working on it.

@ptmaroct
Copy link
Member Author

Yes works fine. Can add a catch handling to revert the available ships value as well but needs to be correct in logic. Discuss the logic once or send a pr

@PREMPRAKASHSINGH PREMPRAKASHSINGH linked a pull request Aug 13, 2024 that will close this issue
Open
@PREMPRAKASHSINGH
Copy link
Contributor

@ptmaroct Raised a PR #28 . Let me know if logic is correct then will remove the commented code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
critical burning issue, should be fixed on priority
Projects
None yet
Milestone
No milestone
2 participants
@ptmaroct @PREMPRAKASHSINGH