Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preParsePostFormat documentation is missing #60

Closed
HELWATANY opened this issue Oct 20, 2021 · 4 comments
Closed

preParsePostFormat documentation is missing #60

HELWATANY opened this issue Oct 20, 2021 · 4 comments

Comments

@HELWATANY
Copy link

HELWATANY commented Oct 20, 2021

After merging pull request #1255 to solve issue #416 on the main repo, the website documentation is missing preParsePostFormat plugin documentation.

The plugin needs to be loaded in order to transform language numerals such as ar displaying "Eastern Arabic numerals" ۰۱۲۳۴۵۶۷۸۹ instead of "Arabic numerals" 0123456789.

@iamkun
Copy link
Member

iamkun commented Nov 1, 2021

Interested to submit a pull request?

@HELWATANY
Copy link
Author

Sure will do 😃

@VehpuS
Copy link
Contributor

VehpuS commented Feb 1, 2022

Already done (just noticed the issue). https://day.js.org/docs/en/plugin/preparse-postformat

Relevant pull request: #58

Hopefully the test was clear enough as a usage example, but now the documentation should hopefully make things clear for any new user.

@iamkun
Copy link
Member

iamkun commented May 3, 2022

done

@iamkun iamkun closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants