Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't set 'site' #4

Open
srakl opened this issue Aug 25, 2021 · 3 comments
Open

can't set 'site' #4

srakl opened this issue Aug 25, 2021 · 3 comments

Comments

@srakl
Copy link

srakl commented Aug 25, 2021

   /**
     * @var string specifies the website name
     * This one is used by Twitter. It is set to Yii::app->name by default
     * @see yii\base\Application::$name
     */
    public $site;

does adding 'site' => '@blabla', in my main.php not set this? it doesn't work for me. It uses Yii::app->name instead

@glpzzz
Copy link
Member

glpzzz commented Aug 25, 2021

Fix incoming. You will just have to add site_name and that will also set site.

This extension requires some review. Thanks for pointing this stuff!

@glpzzz
Copy link
Member

glpzzz commented Aug 25, 2021

@srakl check the new release. Now you can set site and if not set, it takes the value of site_name.

site_name takes the value you set or Yii::$app->name if not.

@srakl
Copy link
Author

srakl commented Aug 25, 2021

Cool, great work.

FYI.

            'site' => '@blabla',
            'site_name' => 'blabla',

i had to set both before it showed. i couldn't just set site and leave site_name empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants