Dialog bug on delete since v7.15.3 of Umbraco #54

martinlcp · 2019-09-12T10:21:46Z

A small bug has bug crept in since the delete dialog was updated to show a confirmation of deleted item(s).

The dialog no longer disappears and now stays on-screen after delete.

I've debugged it and fixed the content-delete.html.

I'm happy to push the changes if you want them?

dawoe · 2019-09-18T14:40:46Z

Hi @martinjgriffiths
Would be great if you could create a PR if you already know how to fix it.

Dave

martinlcp · 2019-09-19T11:27:34Z

Hi @martinjgriffiths
Would be great if you could create a PR if you already know how to fix it.

Dave

Submitted pull request #55

dawoe · 2019-09-19T15:03:29Z

Hi @martinjgriffiths

Your PR has been merged. A new release is rolling out as I am writing this message

dawoe · 2019-09-19T15:03:40Z

Thx for the PR BTW

martinlcp · 2019-09-19T15:04:54Z

Thx for the PR BTW

Np. Also done my first pull request for Umbraco too! It's been a good day. :-)

martinlcp changed the title ~~Dialog bug on delete for since v7.15.3 of Umbraco~~ Dialog bug on delete since v7.15.3 of Umbraco Sep 12, 2019

dawoe closed this as completed Sep 19, 2019

Provide feedback