Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for converting from HEIC? #56

Open
coffeylukas opened this issue May 21, 2019 · 10 comments
Open

Adding support for converting from HEIC? #56

coffeylukas opened this issue May 21, 2019 · 10 comments

Comments

@coffeylukas
Copy link

It would be SUPER helpful to have a conversion from HEIC to JPEG. iPhone images are stored in HEIC (this is changeable in iPhone settings, but using the less efficient images takes up more space), and converting them is always a hassle. Alchemy is already awesome, but it would be more awesome to convert from HEIC to at least JPEG.

@mfix22
Copy link
Member

mfix22 commented May 21, 2019

Hey @coffeylukas great idea! Would you have any interest in working on this? 🙂 Otherwise we can mark it up for prioritization for future releases.

@mfix22
Copy link
Member

mfix22 commented May 21, 2019

For reference for whoever ends up working on this, this package could be useful for Decoding the HEIC image: https://godoc.org/github.com/jdeng/goheif

@jonahisadev
Copy link
Contributor

I know this is kind of old and I'll be busy for the next several days, but I'd be interested in trying to add this feature. Should this be integrated with photosorcery first?

@mfix22
Copy link
Member

mfix22 commented Jul 28, 2019

@jonahisadev that would be amazing!! 🙏 it might be better/easier to add it to photosorcery first, but I’d accept a PR that handles it without that.

Thank you in advance!

@jonahisadev
Copy link
Contributor

For sure! I'm largely working on Linux, so I'll probably start by adding the fix to photosorcery and then adding the change here

@mfix22
Copy link
Member

mfix22 commented Jul 29, 2019

Tremendous!! 🎉

@mfix22
Copy link
Member

mfix22 commented Aug 14, 2019

@jonahisadev hey Jonah 👋 are you still working on this feature? I'd love to include it in the next release! 👌 No rush, just wanted to check in.

@jonahisadev
Copy link
Contributor

@mfix22 Back when I started trying to work on it I think I ran into some problems with Docker so I gave up for a few days and then work got crazy so I forgot. I should have a couple hours tonight to try again. I'll first add it to photosorcery and then to alchemy 👍

@mfix22
Copy link
Member

mfix22 commented Aug 14, 2019

@jonahisadev no worries if not — just wanted to check in 👍

@jonahisadev
Copy link
Contributor

@mfix22 I just wanted to give you an update: unfortunately, this week has been very busy again, and I'll be moving back to school soon so I don't have time to work on this still. Unless someone else gets this, you'll have to leave it out for the next release. When I have some more free time on my hands I'll come back to this and see if it still needs implementing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants