Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

head: title length too long, but actual title is not #173

Open
davidsneighbour opened this issue Jul 16, 2023 · 0 comments
Open

head: title length too long, but actual title is not #173

davidsneighbour opened this issue Jul 16, 2023 · 0 comments
Assignees
@davidsneighbour
Labels
module:head state:confirmed This issue is confirmed. type:bug Bugfixes in codebase when something is not working.

Comments

@davidsneighbour
Copy link
Owner

There is an edge case where "{$pagetitle} {$separator} {$sitetitle}" results in a too long header title tag.

Change this via configuration (dnb.head.config.variable_title(bool) to the following behaviour:

If page title + $separator + $sitetitle is greater than title max length then remove separator and sitetitle

Also add to the SEO meta widget to calculate only $pagetitle without the extensions
@davidsneighbour davidsneighbour self-assigned this Jul 16, 2023
@davidsneighbour davidsneighbour added state:unconfirmed This issue needs to be reproduced. module:head state:confirmed This issue is confirmed. type:bug Bugfixes in codebase when something is not working. and removed state:unconfirmed This issue needs to be reproduced. labels Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidsneighbour davidsneighbour

Labels
module:head state:confirmed This issue is confirmed. type:bug Bugfixes in codebase when something is not working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidsneighbour