fix: restore using latest secret state #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
approved these changes
Mar 14, 2024
renovate bot
referenced
this pull request
in valora-inc/logging
Mar 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fast-redact](https://togithub.com/davidmarkclements/fast-redact) | [`^3.4.0` -> `^3.4.1`](https://renovatebot.com/diffs/npm/fast-redact/3.4.0/3.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>davidmarkclements/fast-redact (fast-redact)</summary> ### [`v3.4.1`](https://togithub.com/davidmarkclements/fast-redact/releases/tag/v3.4.1) [Compare Source](https://togithub.com/davidmarkclements/fast-redact/compare/v3.4.0...v3.4.1) ##### What's Changed - fix: restore using latest secret state by [@​MSala](https://togithub.com/MSala) in [https://github.com/davidmarkclements/fast-redact/pull/69](https://togithub.com/davidmarkclements/fast-redact/pull/69) ##### New Contributors - [@​MSala](https://togithub.com/MSala) made their first contribution in [https://github.com/davidmarkclements/fast-redact/pull/69](https://togithub.com/davidmarkclements/fast-redact/pull/69) **Full Changelog**: davidmarkclements/fast-redact@v3.4.0...v3.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - "after 8:00 before 23:00 every weekday except on Friday" in timezone UTC. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/logging). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are fixing the problem with original object being left mutated after restore execution. It was happening after more than one usage of redact function.
Compiled restore function now always pointing to the latest "secret" state.
Fixed test "does not increment secret size". Previously it was always testing the origin "secret" object, not the restored one, so in general generating false positive.
Extended test: "restores multi nested wildcard values" to cover multiple redact-restore executions.