Fix for TypeError when redact called with leading wildcard and null property #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specialSet was returning `{value, exists}` (no parent) for cases where
the key's value was null. It is supposed to return a `{value, parent,
exists}` triplet. Without `parent`, we get the `TypeError` because the
parent is used in assignment statements.
Set the `oov` variable to `null` on the declaration line.
|
Hi. Would someone kindly merge this PR or let me know what needs to be done to have it merged. Thank you. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set includes a test which illustrates the problem and a suggested fix.
To recap:
Problem is that: path such as
['*.password']gives a type error when redacting an object with a null property,{foo: null}.Reason: a variable was missing an initial value in its declaration