-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up binary releases #207
Comments
Happy to take a look. Although working from a fork, you might need to merge before you can "test". I'll see if I can do a release on my fork though, prior to that. |
I'll do a first version for x86, linux, gnu/musl, with a shell installer (will also work with cargo binstall) |
By default, cargo-dist adds a "dist" profile, that inherits from release, but adds lto="thin", you can let me know if you'd like to avoid the lto....but for a release build it seems reasonable I think. |
And
So I will add those too. |
BTW: I see the wild name in crates is taken. |
If you would like to move a bunch of stuff to workspace Cargo.toml, and inherit them in each package (e.g. homepage, edition, license, authors, maybe align the version numbers? etc). Then just create another issue for me... We'd need to chose a new version number, greater than all previously, and move them all to that... |
Can we configure it to not publish anything to creates.io? We might want to at some stage if there's someone else that wants to use the linker as a library, but for now it seems like an extra thing that we don't need |
Thin LTO sounds good for distribution builds. |
In fact cargo-dist doesn't publish to crates.io for you.
You have to do that as a manual task from your machine.
It does have some requirement (I will need to double check the details)
that the version number in Cargo.toml matches the tag though.
Not sure what it does when there are multiple crates with different version
numbers...
Would you be OK with aligning version numbers across crates.
|
Fine with me to align version numbers. Although I got the impression that it got the version number from the git tag |
Pushed a commit that does that to the PR. |
Great! If you wish, you can push a 0.2.0 tag to the main repo, and you should get a release...then you can edit, generate release notes, edit if you want and you're done. Up to you if you want a separate issue to allow linker-diff to be built on musl. |
There's already a 0.2.0 tag... from March. Must be time for a new version :) But I'll do that tomorrow |
Looks like the two most popular options are cargo-dist and release-plz. I'm not sure what the tradeoffs between them are or which one is likely to be better for our purposes, but it's probably a good idea to have a quick look at both. @andrewdavidmackenzie, would you like to take a look?
The text was updated successfully, but these errors were encountered: