-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include source files in bower "main" #59
Conversation
OK that's interesting as the documentation doesn't say what the main field does and examples never have it as an array. This what gets downloaded when you install via bower.
Can you explain what this change does as I have to admit to being a bit confused by what the |
Ah found the answer to my question. https://github.com/bower/bower.json-spec#main Which say arrays are ok, but this should link to the versions in |
I've changed the bower "main" files to point to the source instead of the minified copy. I've seen either used in other libraries, so though it was left up to the author's preference. Good to know there's a spec for it. |
iframeResizer.contentWindow.min.js
in bower package
I suppose it would be good to mention my primary reason for the pull request. I use grunt-bower-task in my project so that I can manage my Bower dependencies via Grunt tasks. The grunt-bower-task uses what is defined in "main" to copy over the relevant files of the library. Presently, in the case of iframe-resizer, only It makes perfect sense that the Bower spec indicates to include only the unprocessed copy (non-minified) as "main" files since the destination project may have it's own concatenation and minification process (as is true in my case). |
OK I will accept this. The one concern I had was that the two files where not designed to be included in the same built JS file. However, the bug I fixed last week for v2.5.1 should now prevent all the problems that might of caused. |
Include source files in bower "main"
And thank you for the contribution. |
Since
iframeResizer.contentWindow.min.js
is a distributable file, it should be part of the bower package.