-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't close an iframe whose height and width are 0 #170
Comments
This is a browser bug. If you add the following to line 120, does it fix it for you?
|
Nope, the event never makes it out of |
Strange. Do you have a simple test case? Can you paste the log from it. |
I created a pull request for this and referenced the line of code I believe is causing the issue. |
Fixed #171. Thanks Merged. Will do a release at the weekend, when I have a chance to look at a couple of other things. |
If you attempt to close an iframe whose height and width is zero
no change
is detected and the iframe remains in the DOM of the parent window. My current work around is to callwindow.parentIFrame.size(1, 1)
and then subsequently callwindow.parentIFrame.close()
so that a change is registered.The text was updated successfully, but these errors were encountered: