Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer dependencies to support React 19 #611

Closed
mobeigi opened this issue Oct 12, 2024 · 1 comment · Fixed by #612
Closed

Update peer dependencies to support React 19 #611

mobeigi opened this issue Oct 12, 2024 · 1 comment · Fixed by #612

Comments

@mobeigi
Copy link
Contributor

mobeigi commented Oct 12, 2024

Currently we have:

  "peerDependencies": {
    "react": "^16.0.0 || ^17.0.0 || ^18.0.0",
    "react-dom": "^16.0.0 || ^17.0.0 || ^18.0.0"
  },

React 19 is currently in RC and release is around the corner.

Could we update the react peer dependencies to support 19.0.0?

From my inspection, it doesn't look like this project using any functionality that will change / break from 18 to 19 so I believe the change can be made now.

Also I'm personally using this project on production with React 19 RC with no issues.

@rob212
Copy link

rob212 commented Nov 11, 2024

Any updates on when/if this is getting merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants