Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule API should show dates #9

Open
davidcorbin opened this issue Dec 16, 2017 · 3 comments
Open

Schedule API should show dates #9

davidcorbin opened this issue Dec 16, 2017 · 3 comments
Labels

Comments

@davidcorbin
Copy link
Owner

Expected Behavior

The schedule API should have some way of indicating whether the class time is AM or PM. myGCC has AM after classes that end in the morning. If we assume that classes are all less than, for example, 5 hours, we can determine whether the start time is AM or PM.

Actual Behavior

Doesn't tell whether AM or PM.

Specifications

All versions affected.

@mitchharvey
Copy link
Collaborator

Does it actually have am after all classes in the morning? When I wrote it I think I tried to do that but some classes don't have an am or pm (I thought).

@davidcorbin
Copy link
Owner Author

It shows 'AM' when the class ends before 11:59 AM (in the morning). When the class ends after noon, no 'AM' or 'PM' is shown after the time (so we know it is PM).

@mitchharvey
Copy link
Collaborator

Ok sweet that's perfect then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants