Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 'cleanable' properties configurable by user #24

Closed
davelopez opened this issue Apr 18, 2022 · 0 comments · Fixed by #40
Closed

Make 'cleanable' properties configurable by user #24

davelopez opened this issue Apr 18, 2022 · 0 comments · Fixed by #40
Assignees
@davelopez
Labels
enhancement New feature or request

Comments

@davelopez
Copy link
Owner

Right now, the properties considered cleanable (or non-essential) when running the Clean Workflow command (or comparing clean diffs) are hardcoded in:

galaxy-workflows-vscode/server/src/commands/cleanWorkflow.ts

Line 19 in db50562

const CLEANABLE_PROPERTY_NAMES = new Set(["position", "uuid", "errors", "version"]);

We can make these property names configurable via a user setting to make it more flexible.
@davelopez davelopez added the enhancement New feature or request label Apr 18, 2022
@davelopez davelopez self-assigned this Jun 1, 2022
@davelopez davelopez mentioned this issue Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davelopez davelopez

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make cleanable properties user configurable davelopez/galaxy-workflows-vscode
1 participant
@davelopez