From f1222f402055a18d7890e789bcf403321af70e52 Mon Sep 17 00:00:00 2001
From: davelopez <46503462+davelopez@users.noreply.github.com>
Date: Sat, 22 Jun 2024 15:49:02 +0200
Subject: [PATCH] Reduce severity level to Warning for some rules

---
 client/tests/e2e/suite/extension.ga.e2e.ts                    | 4 ++--
 server/gx-workflow-ls-format2/src/profiles.ts                 | 2 +-
 server/gx-workflow-ls-native/src/profiles.ts                  | 2 +-
 .../server-common/src/providers/validation/profiles.ts        | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/client/tests/e2e/suite/extension.ga.e2e.ts b/client/tests/e2e/suite/extension.ga.e2e.ts
index d5bafb9..20d8c26 100644
--- a/client/tests/e2e/suite/extension.ga.e2e.ts
+++ b/client/tests/e2e/suite/extension.ga.e2e.ts
@@ -59,12 +59,12 @@ suite("Native (JSON) Workflows", () => {
         {
           message: "The workflow does not specify a creator.",
           range: new vscode.Range(new vscode.Position(0, 0), new vscode.Position(0, 1)),
-          severity: vscode.DiagnosticSeverity.Error,
+          severity: vscode.DiagnosticSeverity.Warning,
         },
         {
           message: "The workflow does not specify a license.",
           range: new vscode.Range(new vscode.Position(0, 0), new vscode.Position(0, 1)),
-          severity: vscode.DiagnosticSeverity.Error,
+          severity: vscode.DiagnosticSeverity.Warning,
         },
         {
           message: "Missing label in workflow output.",
diff --git a/server/gx-workflow-ls-format2/src/profiles.ts b/server/gx-workflow-ls-format2/src/profiles.ts
index c925738..5e621c4 100644
--- a/server/gx-workflow-ls-format2/src/profiles.ts
+++ b/server/gx-workflow-ls-format2/src/profiles.ts
@@ -36,7 +36,7 @@ export class GxFormat2IWCValidationProfile extends IWCCommonValidationProfile {
     new RequiredPropertyValidationRule(
       "doc",
       true,
-      DiagnosticSeverity.Error,
+      DiagnosticSeverity.Warning,
       "The workflow is not documented. Documenting workflows helps users understand the purpose of the workflow."
     ),
     new InputTypeValidationRule(DiagnosticSeverity.Error),
diff --git a/server/gx-workflow-ls-native/src/profiles.ts b/server/gx-workflow-ls-native/src/profiles.ts
index 1a44e6e..50f0a52 100644
--- a/server/gx-workflow-ls-native/src/profiles.ts
+++ b/server/gx-workflow-ls-native/src/profiles.ts
@@ -33,7 +33,7 @@ export class NativeIWCValidationProfile extends IWCCommonValidationProfile {
     new RequiredPropertyValidationRule(
       "annotation",
       true,
-      DiagnosticSeverity.Error,
+      DiagnosticSeverity.Warning,
       "The workflow is not annotated. Annotating workflows helps users understand the purpose of the workflow."
     ),
     new WorkflowOutputLabelValidationRule(DiagnosticSeverity.Error),
diff --git a/server/packages/server-common/src/providers/validation/profiles.ts b/server/packages/server-common/src/providers/validation/profiles.ts
index 53046e4..5e3cc4b 100644
--- a/server/packages/server-common/src/providers/validation/profiles.ts
+++ b/server/packages/server-common/src/providers/validation/profiles.ts
@@ -47,13 +47,13 @@ export class IWCCommonValidationProfile implements ValidationProfile {
     new RequiredPropertyValidationRule(
       "creator",
       true,
-      DiagnosticSeverity.Error,
+      DiagnosticSeverity.Warning,
       "The workflow does not specify a creator."
     ),
     new RequiredPropertyValidationRule(
       "license",
       true,
-      DiagnosticSeverity.Error,
+      DiagnosticSeverity.Warning,
       "The workflow does not specify a license."
     ),
     // Add more common rules here...