From d442ffc808c1e7f80c87507513251c71872275d6 Mon Sep 17 00:00:00 2001
From: davelopez <46503462+davelopez@users.noreply.github.com>
Date: Thu, 20 Jun 2024 12:09:32 +0200
Subject: [PATCH] Increase test coverage for input validation

---
 .../tests/unit/validation.test.ts             | 49 ++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)

diff --git a/server/packages/workflow-tests-language-service/tests/unit/validation.test.ts b/server/packages/workflow-tests-language-service/tests/unit/validation.test.ts
index ba93fb7..35d8b27 100644
--- a/server/packages/workflow-tests-language-service/tests/unit/validation.test.ts
+++ b/server/packages/workflow-tests-language-service/tests/unit/validation.test.ts
@@ -61,7 +61,7 @@ describe("Workflow Tests Validation Rules", () => {
       rule = new WorkflowInputsValidationRule();
     });
 
-    it("should pass validation when a valid input is defined in the workflow", async () => {
+    it("should pass validation when a valid input is defined in the workflow (inline)", async () => {
       const testDocumentContents = `
   - doc: The docs
     job:
@@ -74,6 +74,20 @@ describe("Workflow Tests Validation Rules", () => {
       expect(diagnostics.length).toBe(0);
     });
 
+    it("should pass validation when a valid input is defined in the workflow", async () => {
+      const testDocumentContents = `
+  - doc: The docs
+    job:
+      My fake dataset:
+        class: File
+    `;
+
+      const diagnostics = await validate(testDocumentContents);
+
+      expect(diagnostics).not.toBeNull();
+      expect(diagnostics.length).toBe(0);
+    });
+
     it("should error when an input is not defined in the workflow", async () => {
       const testDocumentContents = `
   - doc: The docs
@@ -87,6 +101,39 @@ describe("Workflow Tests Validation Rules", () => {
       expect(diagnostics[0].message).toBe('Input "Missing input" is not defined in the associated workflow.');
       expect(diagnostics[0].severity).toBe(DiagnosticSeverity.Error);
     });
+
+    it("should error when an input has an invalid type (inline)", async () => {
+      const testDocumentContents = `
+  - doc: The docs
+    job:
+      My fake string: 5
+    `;
+
+      const diagnostics = await validate(testDocumentContents);
+
+      expect(diagnostics.length).toBe(1);
+      expect(diagnostics[0].message).toBe(
+        'Input "My fake string" has an invalid type. Expected "string" but found "number".'
+      );
+      expect(diagnostics[0].severity).toBe(DiagnosticSeverity.Error);
+    });
+
+    it("should error when an input has an invalid type", async () => {
+      const testDocumentContents = `
+  - doc: The docs
+    job:
+      My fake number:
+        class: string
+    `;
+
+      const diagnostics = await validate(testDocumentContents);
+
+      expect(diagnostics.length).toBe(1);
+      expect(diagnostics[0].message).toBe(
+        'Input "My fake number" has an invalid type. Expected "int" but found "object".'
+      );
+      expect(diagnostics[0].severity).toBe(DiagnosticSeverity.Error);
+    });
   });
 
   describe("WorkflowOutputsValidationRule", () => {