Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Feliz.Engine package #90

Open
MangelMaxime opened this issue Sep 20, 2024 · 5 comments
Open

Issue with Feliz.Engine package #90

MangelMaxime opened this issue Sep 20, 2024 · 5 comments

Comments

@MangelMaxime
Copy link
Contributor

Sutil is using Feliz.Engine for providing an HTML DSL.

The problem is that Feliz.Engine, is not maintained anymore and @alfonsogarciacaro is the only person that has access to the NuGet package.

This is a problem because Feliz.Engine has a few missing API:

I think Sutil should look how to upgrade in the future. I see 2 solutions:

  1. Fork Feliz.Engine
  2. Look into F# existing HTML DSL (there are quite a few 😅) and see if it is possible to re-use an existing one. Or perhaps, if Sutil or the existing HTML DSLs are flexible enough people could use their preferred one to minimise the maintenance.
@davedawkins
Copy link
Owner

I have asked Alfonso for access to the nuget package.

Regarding option (2) - this was the point of creating Feliz.Engine, to have a single implementation that other libraries could use.

Let me see if Alfonso responds. I think I have collaboration access to Feliz.Engine, so we wouldn't need to fork the repo, but we might need to create another package

@MangelMaxime
Copy link
Contributor Author

Sure we can wait for a response from him.

Let me see if Alfonso responds. I think I have collaboration access to Feliz.Engine, so we wouldn't need to fork the repo, but we might need to create another package

Sure, depends if you have full access or limited access I suppose.

@MangelMaxime
Copy link
Contributor Author

I think I can rebuild Feliz.Engine.Bulma, but I don't know about Fable.ShadowStyles.

@davedawkins What do you mean by rebuild? Are you speaking about creating the package or the ability to push the package to NuGet. Because the blocking part if the second one, as you need to have the admin/owner access on NuGet site.

Hello @AngelMunoz, I see that you are the owner of Fable.ShadowStyles. If needed are you still active for maintaining the project or depending on the need would you be ok with adding new maintainers.

Perhaps, @davedawkins can clarify why he mentioned that specific project. I am only starting to experiment with Sutil so I am not well too verse in its code base / needs.

@davedawkins
Copy link
Owner

@MangelMaxime I think you've posted this into the wrong issue. You're responding to an issue about FSharp.Core

@MangelMaxime
Copy link
Contributor Author

@davedawkins Right so for @AngelMunoz, the reason for a rebuild of Fable.ShadowStyles is to lowered FSharp.Core requirements.

See #89 for more context 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants