From 3b4a2055ceb3d3f007cad35f3766431c93ef457d Mon Sep 17 00:00:00 2001 From: Dave Collins Date: Thu, 14 Nov 2013 22:03:41 -0600 Subject: [PATCH] Correct valuesSorter.Less function for uintptr. The function sort be sorting the uintptr itself, not the address of it. Also, the previous code could easily panic on an unaddressable reflect.Value since it was trying to take an address. --- spew/common.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spew/common.go b/spew/common.go index 6f67a0c..0e59eca 100644 --- a/spew/common.go +++ b/spew/common.go @@ -284,7 +284,7 @@ func (s *valuesSorter) Less(i, j int) bool { case reflect.String: return s.values[i].String() < s.values[j].String() case reflect.Uintptr: - return s.values[i].UnsafeAddr() < s.values[j].UnsafeAddr() + return s.values[i].Uint() < s.values[j].Uint() } return s.values[i].String() < s.values[j].String() }