-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripty custom tool holds onto dll file locks #72
Comments
How are you loading the assemblies in your script? I'm assuming with the |
Correct, I'm loading it with the |
When trying to build I get the following VS error.
|
Is this assembly also referenced by your containing project (or is it actually the containing project)? |
The assembly referenced is located in a separate project. I've attached a minimal reproduction solution. |
Just build the solution, run the Content.csx script, then try building the solution again. |
Was this with 0.5.0 or 0.6.0? |
This was with 0.5.0 but I don't think it was fixed for 0.6.0. |
I see it in 0.6.0 also, i think it's VS that's holding the lock. Running the script with the target project unloaded still causes the error until VS is restarted. Killing MSBuild or the VBCSCompiler doesn't release it. Did you try with scripty.exe to see if it locks the file? |
I ran this through the changes I have for PR #75 and its not locking the file. I don't see anything obvious that would cause the reference locking though. |
Now that 0.7.0 is (finally) released, I'll take a look at #75 and we can see if it resolves this issue. |
@TylerBrinkley I know you're currently blocked by #84, and I'm hoping to get an update out for that today. Once it's out can you see if it also resolved this file locking issue? I addition to all the updates to Roslyn, we're also using a new version of the VS extensibility libraries. Perhaps those are better about releasing locks... |
This is still an issue with 0.7.0 of the custom tool which still works with .NET Framework projects. #84 only relates to the Scripty.MSBuild NuGet package. |
Okay, thanks - 0.7.0 has the new VSIX stuff so that's a no-go for this issue then. |
Is it possible this is another symptom of the same problem that's causing #52 ? |
Currently, after running the Scripty custom tool I'm not able to rebuild the solution as Scripty holds onto the references to the .dll files it loads in the csx. I must therefore close Visual Studio and reopen it in order to rebuild the solution.
The text was updated successfully, but these errors were encountered: