Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@portaljs/components improvements #933

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Conversation

demenech
Copy link
Member

@demenech demenech commented Jun 6, 2023

Issue: #912

Changes

  • Added storybook-static to .gitignore and deleted storybook-static
  • Extracted loading spinner from FlatUiTable.tsx into its own component
  • Fixed FlatUiTable loading... size on Firefox
  • Added a couple extra parameters to LineChart i.e. xAxisType, xAxisTimeUnit, yAxisType
  • Added LoadingSpinner to LIneChart
  • Added LoadingSpinner to Table

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: f0c0c9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@portaljs/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
portaljs-alan-turing ⬜️ Ignored (Inspect) Jun 6, 2023 8:55pm
portaljs-ckan ⬜️ Ignored (Inspect) Jun 6, 2023 8:55pm
portaljs-ckan-ssg ⬜️ Ignored (Inspect) Jun 6, 2023 8:55pm
portaljs-fivethirtyeight ⬜️ Ignored (Inspect) Jun 6, 2023 8:55pm
portaljs-git-example ⬜️ Ignored (Inspect) Jun 6, 2023 8:55pm
portaljs-learn ⬜️ Ignored (Inspect) Jun 6, 2023 8:55pm
portaljs-openspending ⬜️ Ignored (Inspect) Jun 6, 2023 8:55pm
portaljs-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2023 8:55pm
site-portaljs ⬜️ Ignored (Inspect) Jun 6, 2023 8:55pm

@demenech demenech linked an issue Jun 6, 2023 that may be closed by this pull request
3 tasks
@luccasmmg
Copy link
Member

LGTM

@luccasmmg luccasmmg merged commit 683159d into main Jun 7, 2023
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@portaljs/components improvements/fixes
2 participants