New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show package revision page requires revision to be tagged #55

Open

shevron opened this issue Sep 1, 2020 · 0 comments

Labels

bug

Contributor

shevron commented Sep 1, 2020

While the functionality of showing a package in a revision that is not tagged isn't exposed in the GUI yet, the backend for it is in place and we want to have that enabled at some point (esp as #24 is implemented). However, it seems that the code in https://github.com/datopian/ckanext-versioning/blob/master/ckanext/versioning/plugin.py#L95 assumes that any revision we load is already tagged.

The expected value of c.current_version is expected to always be a tag info dict, not a revision.

Probably, what we need is to split the view between a tag and a revision, as they are slightly different things.

The text was updated successfully, but these errors were encountered:

shevron added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment