Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile qsv 0.117.0 as it requires rust 1.73 & Homebrew has 1.72.1 #1375

Closed
jqnatividad opened this issue Oct 19, 2023 · 6 comments
Closed
Labels
upstream there is an issue upstream blocking this issue

Comments

@jqnatividad
Copy link
Collaborator

          Currently I can't compile as it requires rust 1.73 and the Mac/Homebrew

only has 1.72.

el

Originally posted by @ondohotola in #1374 (comment)

@jqnatividad jqnatividad changed the title Can't compile qsv 0.117.0 as it requires rust 1.73 and the Mac/Homebrew Can't compile qsv 0.117.0 as it requires rust 1.73 & Homebrew has 1.72.1 Oct 19, 2023
@jqnatividad
Copy link
Collaborator Author

Hi @ondohotola,
That is correct. Please see qsv's latest MSRV policy - https://github.com/jqnatividad/qsv#minimum-supported-rust-version

I do try to wait a week after a Rust stable release to give Homebrew maintainers time to package Rust stable, but if more than a week passes by, I go ahead with the MSRV upgrade.

Hopefully, this adds a nudge, however little, for the HB maintainers to update their Rust formula to the latest Rust stable - Homebrew/homebrew-core#149754.

The HB maintainers are really very good with keeping Rust and qsv formulas up to date, it's just that updating formulas, especially for big packages like Rust is non-trivial.

See Goals/Non-Goals

@jqnatividad
Copy link
Collaborator Author

There is an issue upstream in Rust that's preventing Homebrew from compiling v 1.73.0 on 12-arm

rust-lang/rust#117299

@ondohotola
Copy link

ondohotola commented Oct 31, 2023 via email

@jqnatividad jqnatividad added the upstream there is an issue upstream blocking this issue label Nov 2, 2023
@chenrui333
Copy link

FYI, rust 1.74.0 got shipped in the homebrew side now, Homebrew/homebrew-core#154526

@jqnatividad
Copy link
Collaborator Author

Awesome, been holding off on releasing qsv 0.119.0 till this is resolved.

Releasing it now... :)

@ondohotola
Copy link

Patience is a Virtue :-)-O

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream there is an issue upstream blocking this issue
Projects
None yet
Development

No branches or pull requests

3 participants