Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary release weight ratio doesn't work as expected #1379

Closed
WxFang opened this issue Mar 27, 2019 · 0 comments
Closed

Canary release weight ratio doesn't work as expected #1379

WxFang opened this issue Mar 27, 2019 · 0 comments
Assignees
Milestone

Comments

@WxFang
Copy link

WxFang commented Mar 27, 2019

Describe the bug
A clear and concise description of what the bug is.

To Reproduce

Route same prefix to different services A and B.

  1. If weight_A+weight_B != 100, then only when weight_A/weight_B == 1 or 3 or 4 or 9 this route change will be applied. Or it will be ignored. Amabassador is trying to make normalized weight to be certain numbers.
  2. Another weird issue is that when weight_A = 0 and weight_B = 100, route table will appear 100:100.

Set weights as below and check the route table:
weight_A = 10, weight_B=10
weight_A = 10, weight_B=30
weight_A = 10, weight_B=40
weight_A = 10, weight_B=90
weight_A = 60, weight_B=60
weight_A = 60, weight_B=180
weight_A = 60, weight_B=240
weight_A = 60, weight_B=540

Expected behavior
Whatever the sum is, two weights will be normalized and this change will be applied.

Versions (please complete the following information):

  • Ambassador: [0.50.3]
  • Kubernetes environment [bare metal]
  • Version [v1.13.1]
@kflynn kflynn added this to the pedrera milestone May 9, 2019
@kflynn kflynn self-assigned this Jun 5, 2019
@kflynn kflynn closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants