Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for skipping Secrets list/watch on entrypoint.sh #1293

Closed
esmet opened this issue Mar 6, 2019 · 2 comments
Closed

Support for skipping Secrets list/watch on entrypoint.sh #1293

esmet opened this issue Mar 6, 2019 · 2 comments

Comments

@esmet
Copy link
Contributor

esmet commented Mar 6, 2019

Please describe your use case / problem.

I run Ambassador in a variety of on-premises Kubernetes clusters where Secrets objects are strictly access controlled. Further, my infrastructure terminates TLS outside of Ambassador, and so I do not need any certs/secrets to run Ambassador.

Describe the solution you'd like

I would like for Ambassador to be able to run without trying to list or watch Secrets objects.

I am currently implementing this by removing secrets from the kubewatch line in entrypoint.sh

We could instead support an environment variable to toggle this behavior.

Describe alternatives you've considered

I haven't considered any meaningful alternatives.

Additional context

I think eliminating the need to read Secrets would make Ambassador easier to deploy and adopt at organizations that strictly lock down API access to Secrets objects.

@kflynn
Copy link
Member

kflynn commented Mar 22, 2019

A PR that modifies entrypoint.sh to manage secrets under environment-variable control would be welcome! If you look at the way 0.52.0's entrypoint.sh handles endpoints, it should be pretty clear -- the only difference would be that the environment variable should prevent watching secrets, rather than allow it.

@kflynn
Copy link
Member

kflynn commented Mar 26, 2019

Thanks for the PR!

@kflynn kflynn closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants