Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host_rewrite causes canary deployment to fail #1159

Closed
concaf opened this issue Jan 28, 2019 · 4 comments
Closed

host_rewrite causes canary deployment to fail #1159

concaf opened this issue Jan 28, 2019 · 4 comments
Assignees
Milestone

Comments

@concaf
Copy link
Contributor

concaf commented Jan 28, 2019

I have some test canary configuration like -

      apiVersion: ambassador/v1
      kind:  Mapping
      name:  qotm_mapping_1
      prefix: /qotm/
      service: qotm
      ---
      apiVersion: ambassador/v1
      kind:  Mapping
      name:  qotm_mapping_2
      prefix: /qotm/
      service: httpbin.org:80
      host_rewrite: httpbin.org
      weight: 50

One of the mappings is ignored completely and diag reports the error -

qotm.default.1: cannot accept new mapping qotm_mapping_2 with mismatched host_rewrite: httpbin.org != -unset-

As soon as I remove host_rewrite from the config, the canary starts working fine.

I can reproduce this every time right now, but I have a faint memory that this was intermittent while testing (might help while debugging)

@concaf concaf self-assigned this Jan 28, 2019
@rbudiharso
Copy link

+1 on this, makes the canary not working

@kflynn
Copy link
Member

kflynn commented Jun 18, 2019

So the fundamental issue here is that the host_rewrite element in the Envoy config is an attribute of a Route rather than of a Cluster. That means that we need to sort out how to get Envoy to split traffic across Routes, which we don't currently do.

The docs imply that this is doable, so there's a bit of a research project to sort out how to do it.

@kflynn
Copy link
Member

kflynn commented Jun 18, 2019

(Estimating at 3 because I think it's relatively quick to find out whether the traffic-splitting thing is possible or not, but I'm less sure about exactly how much work lies beyond that.)

@rbudiharso
Copy link

I manage to solve this by specifying host_rewrite on both blocks and the canary starts to work.

@kflynn kflynn modified the milestones: santander, santurtzi Jul 9, 2019
@kflynn kflynn closed this as completed Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants