Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambassador crashes when there are duplicate mappings #1155

Closed
concaf opened this issue Jan 28, 2019 · 2 comments
Closed

Ambassador crashes when there are duplicate mappings #1155

concaf opened this issue Jan 28, 2019 · 2 comments
Assignees
Milestone

Comments

@concaf
Copy link
Contributor

concaf commented Jan 28, 2019

Config that looks like -

      apiVersion: ambassador/v0
      kind:  Mapping
      name:  httpbin_mapping
      prefix: /httpbin-1/
      service: httpbin.org:80
      host: tls-context-host-1
      host_rewrite: httpbin.org
      ---
      apiVersion: ambassador/v0
      kind:  Mapping
      name:  httpbin_mapping
      prefix: /httpbin-2/
      service: httpbin.org:80
      host: tls-context-host-2
      host_rewrite: httpbin.org

crashes Ambassador, and the pod goes in CrashLoopBackOff state. This happens because both the mappings are named the same (httpbin_mapping in this case)

Ambassador should report the error and continue on, instead.

@concaf concaf self-assigned this Jan 28, 2019
@kflynn kflynn added this to the 0.50.0 GA milestone Jan 28, 2019
@kflynn kflynn assigned kflynn and unassigned concaf Jan 28, 2019
@kflynn
Copy link
Member

kflynn commented Jan 28, 2019

I already have a partial fix for this.

@kflynn
Copy link
Member

kflynn commented Jan 30, 2019

Fixed in RC7.

@kflynn kflynn closed this as completed Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants