Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in CodeMirror API #7

Open
sirearsh opened this issue Oct 25, 2021 · 2 comments
Open

change in CodeMirror API #7

sirearsh opened this issue Oct 25, 2021 · 2 comments

Comments

@sirearsh
Copy link

sirearsh commented Oct 25, 2021

Hello sir its been 4 years since you wrote this and here i am using your code. thanks

well there has been a little change in codemirror api, path to content is now ShareDB.data.content
i think when you wrote it must have been ShareDB.data only.

change line 7 in index.js
this.path = path || [];
to
this.path = path || ['content'];
did the trick for me.

sorry i am new to all this i don't know how to put a proper pull requrest for this.

@curran
Copy link
Member

curran commented Oct 26, 2021

Amazing! I have been wanting to update this to work with the latest versions.

Pull requests welcome. I'd be curious how that change impacts the tests.

@curran
Copy link
Member

curran commented Jan 10, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants