Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcement : contributors needed to upgrade to new Kibana versions #62

Open
lfroment-datasweet opened this issue Jan 9, 2020 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@lfroment-datasweet
Copy link

Hi all,
We wish you a happy new year! Thanks for using and starring Kibana-datasweet-formula.

We need your help in order to keep up with the release pace of Kibana.
We are very busy on our business, and preparing a release that might change forever the way you query your elasticsearch data.
In the meantime, we want this plugin to keep up with the new Kibana version, but we are not in a position to do that by ourselves.
Are any of you willing to contribute ? If so, please let us know. Support for 7.5 would be the priority.
Best regards
Datasweet team.

@lfroment-datasweet lfroment-datasweet changed the title Announcement : contributors needed Announcement : contributors needed to upgrade to new Kibana versions Jan 23, 2020
@pchakour
Copy link

pchakour commented Feb 7, 2020

If you are a simple user, don't use this patch. The saved object structure are not the same than datasweet 2.2.1 and can lead to some compatibility issues in the futur.

Hey guys :)

I'm working on the migration for Kibana 7.5.0 and I need some helps.
I think everything seems to work but I had to patch directly the code inside kibana to migrate some parts of the code. So, if someone can take a look to see if we can avoid patches and do everything in the plugin, it will be better (may be using prototype) .

So this is a git patch to apply on datasweet plugin
datasweet.patch.zip

To apply it, you have to :

  • clone the datasweet plugin
  • checkout the tag v2.2.1
  • unzip the patch inside the plugin repository
  • use this command to apply the patch : git am --signoff -k < datasweet.patch.git
  • execute the script apply.sh inside the directory patches : cd patches && sh ./apply.sh
  • execute the yarn command
  • start kibana (remove the content of the optimize directory before if you are not in dev mode)

@lfroment-datasweet lfroment-datasweet added the help wanted Extra attention is needed label Mar 18, 2020
@pchakour
Copy link

pchakour commented Mar 23, 2020

Hi !

This is a new patch for kibana 7.6.1 :
datasweet_7.6.1.zip
datasweet_7.6.1.zip (Fix a bug in prod mode)

The installation instructions are :

  • clone the datasweet plugin
  • checkout the tag v2.2.1
  • unzip the patch inside the plugin repository
  • use this command to apply the patch : git am --signoff -k < datasweet.patch.git
  • execute the script apply.sh inside the directory patches :
    cd patches && sh ./apply.sh (For dev mode)
    cd patches && sh ./apply.sh prod (For prod mode)
  • execute the yarn install command
  • start kibana (remove the content of the optimize directory before if you are not in dev mode)

This patch :

  • Add the support for Kibana 7.6.1
  • Keep the same structure of the saved object than the datasweet 2.2.1

@alex-cristescu
Copy link

Hello,

Is the 7.6.1 version of the plugin also compatible with Kibana 7.6.2 or does it need changes?

Asking as we've installed the plugin on 7.6.2 however we cannot see it inside the visualization builder nor in the status page listed in the Kibana plugin list

root@elk7-stack-ansible:/usr/share/kibana/kibana-datasweet-formula_tree_v2.2.1/kibana-datasweet-formula/patches# /usr/local/bin/yarn install

yarn install v1.22.4

warning ../../package.json: License should be a valid SPDX license expression

[1/4] Resolving packages...

[2/4] Fetching packages...

[3/4] Linking dependencies...

warning " > [email protected]" has incorrect peer dependency "eslint@^1.4.1".

[4/4] Building fresh packages...

success Saved lockfile.

Done in 6.94s.

Thanks

@pchakour
Copy link

pchakour commented Apr 10, 2020

Yes, I think the patch is compatible with kibana 7.6.2.

My installation instructions seems to be unclear because lots of people have issues with the installation of my patch :(

First, delete your attempt to avoid conflicts:

cd /usr/share/kibana/
rm -rf kibana-datasweet-formula_tree_v2.2.1

Then, use the following commands to install the plugin:

cd /usr/share/kibana/
mkdir -p plugins
cd plugins
git clone https://github.com/datasweet/kibana-datasweet-formula.git
cd kibana-datasweet-formula
git checkout v2.2.1
git am --signoff -k < PATCH_PATH
cd patches
sh ./apply.sh prod
cd ..
yarn install
cd ..
rm -rf optimize/*

After restarting your kibana, it will work...

Of course, you have to replace PATCH_PATH with the path of the extracted patch.
Let me know if you any troubles...

@scaramatto
Copy link

Sorry

Yes, I think the patch is compatible with kibana 7.6.2.

My installation instructions seems to be unclear because lots of people have issues with the installation of my patch :(

First, delete your attempt to avoid conflicts:

cd /usr/share/kibana/
rm -rf kibana-datasweet-formula_tree_v2.2.1

Then, use the following commands to install the plugin:

cd /usr/share/kibana/
mkdir -p plugins
cd plugins
git clone https://github.com/datasweet/kibana-datasweet-formula.git
cd kibana-datasweet-formula
git checkout v2.2.1
git am --signoff -k < PATCH_PATH
cd patches
sh ./apply.sh prod
cd ..
yarn install
cd ..
rm -rf optimize/*

After restarting your kibana, it will work...

Of course, you have to replace PATCH_PATH with the path of the extracted patch.
Let me know if you any troubles...

Sorry... For Windows how i can install plugin to kibana 7.6.1?
This command they only work with linux :(
Thanks!

@charlotth charlotth pinned this issue Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants