Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some TS types should be nullable #45

Closed
banacorn opened this issue Sep 17, 2021 · 1 comment · Fixed by #46 or #47
Closed

Some TS types should be nullable #45

banacorn opened this issue Sep 17, 2021 · 1 comment · Fixed by #46 or #47
Assignees
Labels
enhancement New feature or request

Comments

@banacorn
Copy link

Some function returns null:

console.log(bst.lowerBound(60).getKey()); // 60
console.log(bst.lowerBound(60, false).getKey()); // 50
console.log(bst.lowerBound(10)); // null

However, this is not reflected in the TS type definition file

lowerBound(k: T, includeEqual?: boolean): BinarySearchTreeNode<T, U>;

@eyas-ranjous
Copy link
Member

Thanks for reporting @banacorn I I'll fix this soon.

@eyas-ranjous eyas-ranjous self-assigned this Oct 6, 2021
@eyas-ranjous eyas-ranjous added the enhancement New feature or request label Oct 6, 2021
@eyas-ranjous eyas-ranjous linked a pull request Oct 13, 2021 that will close this issue
@eyas-ranjous eyas-ranjous linked a pull request Nov 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants