Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add test coverage tool for client-python #3517

Closed
noidname01 opened this issue May 23, 2024 · 0 comments · Fixed by #3541
Closed

[Improvement] Add test coverage tool for client-python #3517

noidname01 opened this issue May 23, 2024 · 0 comments · Fixed by #3541
Assignees
@noidname01
Labels
improvement Improvements on everything

Comments

@noidname01
Copy link
Collaborator

What would you like to be improved?

  • Currently we don't have test coverage in client-python, we should add coverage tool to check our tests

How should we improve?

No response
@noidname01 noidname01 added the improvement Improvements on everything label May 23, 2024
This was referenced May 23, 2024
Merged
Merged
jerryshao pushed a commit that referenced this issue May 24, 2024
@noidname01
[#3517] improvement(client-python): Add Coverage as python test cover…
17ed48b 
…age tool (#3541)

### What changes were proposed in this pull request?

* Merge test coverage into Gradle tasks
* Generate html report for both unit and integration tests
(`htmlcov/index.html` under their folders)

The generated html report is as follows:

Unit Test Covergae:
<img width="1202" alt="image"
src="https://github.com/datastrato/gravitino/assets/55401762/e58d6513-e574-4b25-a8e7-81622bd46431">

Integration Test Coverage:
<img width="1201" alt="image"
src="https://github.com/datastrato/gravitino/assets/55401762/31a37db5-528f-4810-af8e-ca3ec21bc6de">


### Why are the changes needed?

Fix: #3517

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

---------

Co-authored-by: TimWang <[email protected]>
noidname01 added a commit to noidname01/gravitino that referenced this issue May 24, 2024
@noidname01
[apache#3517] improvement(client-python): Add Coverage as python test…
de08a7a 
… coverage tool (apache#3541)

### What changes were proposed in this pull request?

* Merge test coverage into Gradle tasks
* Generate html report for both unit and integration tests
(`htmlcov/index.html` under their folders)

The generated html report is as follows:

Unit Test Covergae:
<img width="1202" alt="image"
src="https://github.com/datastrato/gravitino/assets/55401762/e58d6513-e574-4b25-a8e7-81622bd46431">

Integration Test Coverage:
<img width="1201" alt="image"
src="https://github.com/datastrato/gravitino/assets/55401762/31a37db5-528f-4810-af8e-ca3ec21bc6de">


### Why are the changes needed?

Fix: apache#3517

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

---------

Co-authored-by: TimWang <[email protected]>
@noidname01 noidname01 mentioned this issue May 24, 2024
Merged
jerryshao pushed a commit that referenced this issue May 24, 2024
@noidname01
[#3517] improvement(client-python): Add Coverage as python test cover…
2c57aeb 
…age tool (#3545)

### What changes were proposed in this pull request?

* Merge test coverage into Gradle tasks
* Generate html report for both unit and integration tests
(`htmlcov/index.html` under their folders)

The generated html report is as follows:

Unit Test Covergae:
<img width="1202" alt="image"

src="https://github.com/datastrato/gravitino/assets/55401762/e58d6513-e574-4b25-a8e7-81622bd46431">

Integration Test Coverage:
<img width="1201" alt="image"

src="https://github.com/datastrato/gravitino/assets/55401762/31a37db5-528f-4810-af8e-ca3ec21bc6de">


### Why are the changes needed?

Fix: #3517

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

Co-authored-by: TimWang <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@noidname01 @diqiu50
[apache#3517] improvement(client-python): Add Coverage as python test…
7bd2e04 
… coverage tool (apache#3541)

### What changes were proposed in this pull request?

* Merge test coverage into Gradle tasks
* Generate html report for both unit and integration tests
(`htmlcov/index.html` under their folders)

The generated html report is as follows:

Unit Test Covergae:
<img width="1202" alt="image"
src="https://github.com/datastrato/gravitino/assets/55401762/e58d6513-e574-4b25-a8e7-81622bd46431">

Integration Test Coverage:
<img width="1201" alt="image"
src="https://github.com/datastrato/gravitino/assets/55401762/31a37db5-528f-4810-af8e-ca3ec21bc6de">


### Why are the changes needed?

Fix: apache#3517

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

---------

Co-authored-by: TimWang <[email protected]>
coolderli pushed a commit that referenced this issue Dec 17, 2024
@noidname01
[#3517] improvement(client-python): Add Coverage as python test cover…
3effac6 
…age tool (#3541)

### What changes were proposed in this pull request?

* Merge test coverage into Gradle tasks
* Generate html report for both unit and integration tests
(`htmlcov/index.html` under their folders)

The generated html report is as follows:

Unit Test Covergae:
<img width="1202" alt="image"
src="https://github.com/datastrato/gravitino/assets/55401762/e58d6513-e574-4b25-a8e7-81622bd46431">

Integration Test Coverage:
<img width="1201" alt="image"
src="https://github.com/datastrato/gravitino/assets/55401762/31a37db5-528f-4810-af8e-ca3ec21bc6de">

### Why are the changes needed?

Fix: #3517

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

---------

Co-authored-by: TimWang <[email protected]>
(cherry picked from commit 17ed48b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noidname01 noidname01

Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3517] improvement(client-python): Add Coverage as python test coverage tool noidname01/gravitino
2 participants
@jerryshao @noidname01