Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] With only one metalake UI presents user with a choice #3285

Closed
justinmclean opened this issue May 7, 2024 · 2 comments · Fixed by #3385
Closed

[Bug report] With only one metalake UI presents user with a choice #3285

justinmclean opened this issue May 7, 2024 · 2 comments · Fixed by #3385
Assignees
@LauraXia123
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@justinmclean
Copy link
Member

Version

main branch

Describe what's wrong

It looks like you can select from multiple metalake when there is only one metalake
image

Error message and/or stacktrace

N/A

How to reproduce

Start the playground and look at the demo metalake.

Additional context

No response
@justinmclean justinmclean added bug Something isn't working good first issue Good for newcomers labels May 7, 2024
@shaofengshi
Copy link
Contributor

Justin, what's your suggstion? disable the drow-down list if there is only one choice?

@justinmclean
Copy link
Member Author

I would either a) show a single entry and no drop-down list if there is only one metalake or b) not show it at all.

@LauraXia123 LauraXia123 self-assigned this May 14, 2024
LauraXia123 added a commit to LauraXia123/gravitino that referenced this issue May 14, 2024
@LauraXia123
[apache#3285]fix(ui): disable the metalake select with only one
0b169a1
@LauraXia123 LauraXia123 mentioned this issue May 14, 2024
Merged
LauraXia123 added a commit that referenced this issue May 15, 2024
@LauraXia123
[#3285] fix(web): disable the metalake select with only one (#3385)
92dcabf 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
disable the metalake select with only one
<img width="505" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/f91df10f-3856-4947-a8cb-6e6cdbe004f3">

### Why are the changes needed?
With only one metalake UI presents user with a choice

Fix: #3285

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manual
github-actions bot pushed a commit that referenced this issue May 15, 2024
@LauraXia123 @web-flow
[#3285] fix(web): disable the metalake select with only one (#3385)
28eebee 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
disable the metalake select with only one
<img width="505" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/f91df10f-3856-4947-a8cb-6e6cdbe004f3">

### Why are the changes needed?
With only one metalake UI presents user with a choice

Fix: #3285

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manual
@jerryshao jerryshao mentioned this issue May 15, 2024
Merged
LauraXia123 added a commit that referenced this issue May 15, 2024
@jerryshao @LauraXia123
[#3285] fix(web): disable the metalake select with only one (#3395)
98db7ec 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
disable the metalake select with only one
<img width="505" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/f91df10f-3856-4947-a8cb-6e6cdbe004f3">

### Why are the changes needed?
With only one metalake UI presents user with a choice

Fix: #3285

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manual

Co-authored-by: Qian Xia <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@LauraXia123 @diqiu50
[apache#3285] fix(web): disable the metalake select with only one (ap…
f6976e2 
…ache#3385)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
disable the metalake select with only one
<img width="505" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/f91df10f-3856-4947-a8cb-6e6cdbe004f3">

### Why are the changes needed?
With only one metalake UI presents user with a choice

Fix: apache#3285

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LauraXia123 LauraXia123

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3285] fix(web): disable the metalake select with only one LauraXia123/gravitino
3 participants
@justinmclean @shaofengshi @LauraXia123